refactor(rule-engine): Revamp rule engine #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitstack
force-pushed
the
refactor-rule-engine
branch
2 times, most recently
from
b090181 to
9117275
Compare
Refactor the rule engine code by moving it into a separate package and segregating the main building blocks into distinct source files. Along the way, shift the state machine states from expression names to simple integer indices representing sequence ids.
The match all rule engine strategy permits a single event to trigger multiple rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Refactor the rule engine code by moving it into a separate package and segregating the main building blocks into distinct source files. Along the way, shift the state machine states from expression names to simple integer indices representing sequence IDs.
As a side effect of the refactoring, a new config flag is introduced to designate if the rule engine match all strategy is enabled. If this strategy is enabled, a single event can trigger multiple rules, both simple and sequence rules.
What type of change does this PR introduce?
/kind feature (non-breaking change which adds functionality)
/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)
Any specific area of the project related to this PR?
/area rule-engine
Special notes for the reviewer
Does this PR introduce a user-facing change?
Convey the new rule engine match strategy and highlight that the match all strategy is enabled by default.